Atlassian Lead Craft • The Code Review Interview Round

The Engineering Lead's Code Review & PR Teardown Workshop

Atlassian, Google, and Canva don't just ask managers to write code—they test how you **evaluate, protect, and mentor** your team through Pull Requests. Here is how seasoned leaders spot catastrophic bugs while building engineer confidence.

Check-Then-Act Race Conditions Memory Leaks & OOM Protections Empathetic Coaching Rubric

Interactive PR Teardowns

Select a real-world case study
TARGET PR ARTIFACTAuthor: Junior Engineer

PR #418: User Notification Dispatcher (The Over-Engineering Trap)

Instead of writing a simple, cohesive adapter, they created an abstract generic factory with 4 layers of inheritance, swallowed error handling, and zero automated tests.

UNREVIEWED PULL REQUEST DIFFTypeScript
// src/services/notifications/NotificationManager.ts
export class NotificationManager {
  private static instance: NotificationManager;
  private adapterFactory: any;

  private constructor() {
    // Dynamically loading adapters via reflection
    this.adapterFactory = require("./factories/DynamicAdapterFactory");
  }

  public static getInstance(): NotificationManager {
    if (!NotificationManager.instance) {
      NotificationManager.instance = new NotificationManager();
    }
    return NotificationManager.instance;
  }

  public async dispatchAlert(channel: string, payload: any): Promise<boolean> {
    try {
      const adapter = this.adapterFactory.createAdapter(channel);
      await adapter.send(payload);
      return true;
    } catch (err) {
      // Swallowed error: silent failure in production!
      console.log("Failed to send notification: " + err);
      return false;
    }
  }
}

Line-by-Line EM Critique (Interactive Self-Test Mode)

Line 24-29 • Silent Error SwallowingCRITICAL
Can you spot why an Atlassian EM flags Line 24-29 before revealing?
Line 2-17 • Premature Singleton & Dynamic ReflectionCOACHING
Can you spot why an Atlassian EM flags Line 2-17 before revealing?
Overall • Zero Unit Tests ProvidedHIGH
Can you spot why an Atlassian EM flags Overall before revealing?
The Leadership Takeaway

A junior PR is an opportunity for mentorship, not a gatekeeping exercise. Guide them toward simplicity, explicit observability, and testability.

EXECUTIVE CODE REVIEW MATRIX

The 4-Pillar Code Review Checklist for Leads

Memorize this 4-part mental checklist before your interview. It allows you to systematically audit any codebase or take-home prompt in under 5 minutes.

1. Correctness & Concurrency

  • Are state mutations atomic? Are there check-then-act race conditions across async boundaries?
  • Are error boundaries explicit, or are exceptions being silently swallowed?
  • How does this behave under 0 items, 1 item, and 100,000 items?

2. Observability & Operability

  • If this feature breaks at 2:00 AM on a Saturday, will the on-call engineer have metrics, logs, and alerts to diagnose it in under 5 minutes?
  • Are sensitive customer credentials (PII, tokens) stripped from log payloads?
  • Does this service introduce unmetered memory allocations or unbounded arrays?

3. Architecture & Testability

  • Can this component be unit tested without spinning up an entire database or mock server?
  • Is business logic decoupled from transport layers (HTTP / WebSockets)?
  • Is the design proportionate to the problem, or is it bloated with premature design patterns?

4. Mentorship & Psychological Safety

  • Does the feedback explain the *why*, rather than issuing peremptory demands?
  • Is praise given for good decisions alongside corrective guidance?
  • Are suggestions framed as collaborative questions (&ldquo;What happens if...&rdquo;) rather than attacks?
Interactive AI Simulator Rehearsal

Practice Defending Code Decisions with AI

Step into a live simulator session. Practice negotiating technical standards with an opinionated AI Principal Engineer or giving constructive feedback to a defensive developer.